Skip to content

Conversation

chenrui333
Copy link
Member

aider: use brewed pillow dependency

Signed-off-by: Rui Chen <rui@chenrui.dev>
@Copilot Copilot AI review requested due to automatic review settings October 19, 2025 20:47
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR configures the aider formula to use the system-provided Pillow dependency from Homebrew instead of building it from PyPI. This change aligns with Homebrew's best practice of reusing common dependencies across formulas.

  • Adds "pillow" to the list of excluded PyPI packages for the aider formula
  • Adds a dependency on the brewed "pillow" formula
  • Removes the inline Pillow resource definition

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pypi_formula_mappings.json Adds "pillow" to the exclude_packages list for aider to prevent installing it from PyPI
Formula/a/aider.rb Adds pillow as a formula dependency and removes the inline pillow resource block

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 19, 2025
@chenrui333 chenrui333 added python Python use is a significant feature of the PR or issue CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. ready to merge PR can be merged once CI is green and removed automerge-skip `brew pr-automerge` will skip this pull request CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Oct 19, 2025
Copy link
Member

@botantony botantony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 20, 2025
@BrewTestBot BrewTestBot enabled auto-merge October 20, 2025 00:25
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 20, 2025
Merged via the queue into main with commit a074d61 Oct 20, 2025
22 checks passed
@BrewTestBot BrewTestBot deleted the aider-pillow branch October 20, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. python Python use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants